Re: Support logical replication of DDLs

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Support logical replication of DDLs
Date: 2023-05-22 05:56:48
Message-ID: CAJpy0uCGnRQnpNVQaApRxqN=9t5VpHRk5b+Mfdf3cqCEW=s+4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Wed, May 17, 2023 at 4:45 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 17 May 2023 at 15:41, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Fri, May 12, 2023 at 12:03 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > >
> > > On Tue, May 9, 2023 at 4:23 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > >
> > > > On Mon, May 8, 2023 at 4:31 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > > >
> > > > > On Mon, May 8, 2023 at 3:58 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > > > >
> > > > > > On Tue, May 2, 2023 at 8:30 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > > > > >
> > > > > > > On Fri, Apr 28, 2023 at 5:11 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > > > > > >
> > > > > > > > Now, I think we can try to eliminate this entire ObjTree machinery and
> > > > > > > > directly from the JSON blob during deparsing. We have previously also
> > > > > > > > discussed this in an email chain at [1]. I think now the functionality
> > > > > > > > of JSONB has also been improved and we should investigate whether it
> > > > > > > > is feasible to directly use JSONB APIs to form the required blob.
> > > > > > >
> > > > > > > +1.
> > > > > > > I will investigate this and will share my findings.
> > > > > > >
> > > > > >
> > > > > >
> > > > > > Please find the PoC patch for create-table after object-tree removal.
> > > > >
> > > >
> > >
> > > Please find the new set of patches attached for object-tree removal.
> >
> > Please find the new set of patches for object-tree Removal. The new
> > changes are in patch 0008 only. The new changes incorporate the
> > object-tree removal for 'alter table' command.
>

Please find the new set of patches for object-tree Removal. The new
changes are in patch 0008 only. The new changes address object tree
removal for below commands.

create sequence
alter sequence
alter object owner to
alter object set schema
alter object rename

In this patch 0008, ddldeparse.c is now object-tree free for all the
table related commands. Index related commands are yet to be done.

thanks
Shveta

Attachment Content-Type Size
0001-Deparser-for-Table-DDL-commands-and-exten-2023_05_22.patch application/octet-stream 167.5 KB
0005-DDL-replication-for-Table-DDL-commands-2023_05_22.patch application/octet-stream 248.1 KB
0003-Add-verbose-option-for-ddl-deparse-module-2023_05_22.patch application/octet-stream 47.2 KB
0002-Enhance-the-event-trigger-to-support-DDL--2023_05_22.patch application/octet-stream 33.9 KB
0004-Introduce-the-test_ddl_deparse_regress-te-2023_05_22.patch application/octet-stream 977.8 KB
0006-Add-subscription-tap-test-for-DDL-replica-2023_05_22.patch application/octet-stream 20.8 KB
0007-Apply-the-DDL-change-as-that-same-user-th-2023_05_22.patch application/octet-stream 60.0 KB
0008-ObjTree-Removal-for-multiple-commands-2023_05_22.patch application/octet-stream 1.7 MB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tiffany Thang 2023-05-22 06:14:06 Re: Profiling a function call
Previous Message Kirk Wolak 2023-05-22 05:19:21 Re: Adding SHOW CREATE TABLE

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-05-22 06:42:28 Re: createuser --memeber and PG 16
Previous Message Kirk Wolak 2023-05-22 05:19:21 Re: Adding SHOW CREATE TABLE