| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A new C function `get_partition_root`. |
| Date: | 2026-07-30 03:41:29 |
| Message-ID: | CAJpy0uBjUY5JFYFrHvpzBH_OSt90J3uRi5NHaN6yutmcYa3m5w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 30, 2026 at 5:35 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Jul 29, 2026 at 7:18 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Wed, Jul 29, 2026 at 2:28 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> ...
> > > BTW, although I think using sanity Assert was correct, just in case
> > > there is some unanticipated way to reach the C function with a bad
> > > relid, I've changed to use an errlog(ERROR).
> > > Thoughts?
> >
> > I don't immediately see any such possibility. I feel Assert is better.
> >
>
> OK. PSA v4, which is the same as v3, but uses Assert instead of elog.
>
Looks good.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-07-30 03:43:19 | Re: question about is_valid parameter in set_attnotnull |
| Previous Message | shihao zhong | 2026-07-30 03:38:04 | Re: lazy_scan_heap: avoid vacuum block, already vacuumed (src/backend/access/heap/vacuumlazy.c) |