| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: A new C function `get_partition_root`. |
| Date: | 2026-07-30 00:04:40 |
| Message-ID: | CAHut+PtRi4S=O5FWA3_b005T9CwHR07X-mhja_UuRUYdX+XUgQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 29, 2026 at 7:18 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, Jul 29, 2026 at 2:28 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
...
> > BTW, although I think using sanity Assert was correct, just in case
> > there is some unanticipated way to reach the C function with a bad
> > relid, I've changed to use an errlog(ERROR).
> > Thoughts?
>
> I don't immediately see any such possibility. I feel Assert is better.
>
OK. PSA v4, which is the same as v3, but uses Assert instead of elog.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-C-function-get_partition_root.patch | application/octet-stream | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-07-30 00:10:16 | Re: DOCS QUESTION - space added within synopsis replaceable tag. |
| Previous Message | Michael Paquier | 2026-07-29 23:18:21 | Re: Add pg_stat_kind_info system view |