| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Replication slot is not able to sync up |
| Date: | 2025-06-16 03:56:54 |
| Message-ID: | CAJpy0uBYHayRi-BpX-gKe7edFPDL8JUFwRO3Y9JW5ByorLUPjw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 14, 2025 at 11:08 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > I feel WARNING and CAUTION markups could be a little strong for the
> > concerned case. Such markups are generally used when there is a
> > side-effect involved with the usage. But in our case, there is no such
> > side-effect with the API. At max it may fail without harming the
> > system and will succeed in the next invocation. But I also feel that
> > such sections catch user attention. Thus if needed, we can have a NOTE
> > section to convey the recommended way of slot synchronization.
> >
>
> I think NOTE is fine for API in this case, but we can mention that the
> API is more prone to get the synchronization failure message, as you
> have shown in the patch. It would also be better to briefly explain in
> user terms why the API is more prone to such a failure.
>
Thanks Peter and Amit for feedback. I have updated the patch.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Improve-log-messages-and-docs-for-slotsync.patch | application/octet-stream | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-06-16 03:59:21 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-06-16 03:54:18 | RE: Replication slot is not able to sync up |