Re: Replication slot is not able to sync up

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replication slot is not able to sync up
Date: 2025-06-14 05:37:49
Message-ID: CAA4eK1KkVWECy1SPFDbDeBXvMTBgMXQHTedbz1PR2hQpSvMjEA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 12, 2025 at 10:44 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Jun 12, 2025 at 4:13 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Phrases like "... it is recommended..." and "... intended for testing
> > and debugging .. " and "... should be used with caution." and "... it
> > is advisable to..." seem like indicators that parts of the above
> > description should be using SGML markup such as <caution> or <warning>
> > or <note> instead of just plain text.
> >
>
> I feel WARNING and CAUTION markups could be a little strong for the
> concerned case. Such markups are generally used when there is a
> side-effect involved with the usage. But in our case, there is no such
> side-effect with the API. At max it may fail without harming the
> system and will succeed in the next invocation. But I also feel that
> such sections catch user attention. Thus if needed, we can have a NOTE
> section to convey the recommended way of slot synchronization.
>

I think NOTE is fine for API in this case, but we can mention that the
API is more prone to get the synchronization failure message, as you
have shown in the patch. It would also be better to briefly explain in
user terms why the API is more prone to such a failure.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-06-14 07:04:28 Re: Make tuple deformation faster
Previous Message Amit Kapila 2025-06-14 05:26:52 Re: pg_recvlogical cannot create slots with failover=true