| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Doruk Yilmaz <doruk(at)mixrank(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: [Patch] add new parameter to pg_replication_origin_session_setup |
| Date: | 2026-03-25 09:33:27 |
| Message-ID: | CAJpy0uB-orRxTL-8MJ+i9riBZkvVdP_T+p71GyHnJRYw-MrXVg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2026 at 1:51 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Feb 11, 2026 at 5:09 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > >
> > > I see your point but one advantage with the proposed code change is
> > > that it started to appear that we can extend this part of code easily
> > > in the future as it separates most of the handling related to when a
> > > user has given acquired_by parameter's value as zero and non-zero.
> >
> > Okay, yes. So I am okay with it. The slight change I suggested (if to
> > else-if) and a comment will make it more clean.
> >
>
> I have tried to address both your suggestions in the attached. See, if
> this looks okay to you now?
>
LGTM now, thanks!
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-03-25 09:34:47 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Jim Jones | 2026-03-25 09:21:56 | Re: COMMENTS are not being copied in CREATE TABLE LIKE |