Re: [Patch] add new parameter to pg_replication_origin_session_setup

On Wed, Mar 25, 2026 at 3:03 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, Mar 25, 2026 at 1:51 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Wed, Feb 11, 2026 at 5:09 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > >
> > > On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > I see your point but one advantage with the proposed code change is
> > > > that it started to appear that we can extend this part of code easily
> > > > in the future as it separates most of the handling related to when a
> > > > user has given acquired_by parameter's value as zero and non-zero.
> > >
> > > Okay, yes. So I am okay with it. The slight change I suggested (if to
> > > else-if) and a comment will make it more clean.
> > >
> >
> > I have tried to address both your suggestions in the attached. See, if
> > this looks okay to you now?
> >
>
> LGTM now, thanks!
>

Pushed.

--
With Regards,
Amit Kapila.