| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-10-19 08:12:06 |
| Message-ID: | 55D5B29A-E691-4C27-B75B-1CE1A0A7499C@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 19, 2026, at 14:57, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi hackers.
>
> (This is a DOCS improvement patch only)
>
> This patch was originally in another thread, where it was suggested
> [1] to post separately (here), since it is an independent improvement.
>
> ~
>
> The "CREATE PUBLICATION" docs [2] say:
> "This does not apply to a partitioned table, however."
>
> It is ambiguous as to exactly what "this" refers to:
> - does "this" mean just the '*' of the prior sentence?
> - does "this" relate to the whole 'ONLY'/'*' discussion?
>
> The patch removes the ambiguity. PSA v1.
>
> ======
> [1] https://www.postgresql.org/message-id/19bc00e8-ed58-488d-a727-5bca2445b795%40gmail.com
> [2] https://www.postgresql.org/docs/devel/sql-createpublication.html
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-DOCS-Remove-ambiguous-wording-about-ONLY-for-part.patch>
I think this is an improvement by making the meaning of ONLY and * clearer.
I just have nit comment:
```
+ the publication, so they are never explicitly added to the publication.
```
“so they are never explicitly added to the publication” might be read as a child partition cannot be added explicitly, however I verified the following is valid:
```
CREATE TABLE p (id integer) PARTITION BY RANGE (id);
CREATE TABLE p1 PARTITION OF p FOR VALUES FROM (0) TO (100);
CREATE PUBLICATION pub FOR TABLE p, p1;
```
So, how about:
```
the publication, so they do not need to be explicitly added to the
publication.
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wenhui qiu | 2026-10-19 08:14:18 | Re: "variable not found in subplan target lists" with partitionwise join |
| Previous Message | Chao Li | 2026-10-19 07:30:45 | Re: Fix stale allocChunkLimit when recycling AllocSet |