Re: Missing list_free in publicationcmds.c:OpenTableList

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Missing list_free in publicationcmds.c:OpenTableList
Date: 2026-07-29 03:44:09
Message-ID: CAJpy0uA4uVCknX=QzxNLrt4vP7Y=xKT54hEchahx9cWHB_Tr8g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 28, 2026 at 10:30 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> FWIW, I detected a missing `list_free`, which seems to have been
> accidentally left out from commit 923def9.
>
> Added:
> list_free(relids_with_collist);
>
> Consistent with the existing:
> list_free(relids_with_rf);
>

Okay since list_free for both relids and relids_with_rf are there, I
think list_free for 'relids_with_rf' also make sense. So LGTM.

thanks
Shveta

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Chen 2026-07-29 03:45:05 Re: [Patch] Don't stop a `vacuumdb --all` on a connection failure
Previous Message Amit Kapila 2026-07-29 03:36:22 Re: [Bug] pg_upgrade could fail for non-superuser subscriptions using foreign servers