Re: Missing list_free in publicationcmds.c:OpenTableList

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Missing list_free in publicationcmds.c:OpenTableList
Date: 2026-07-29 04:25:17
Message-ID: CAGRkXqSDG6ZeyjG_fD7+J0QR4SssoYPxPTEG9etgPdc6LF-7GQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 28, 2026 at 11:44 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, Jul 28, 2026 at 10:30 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > FWIW, I detected a missing `list_free`, which seems to have been
> > accidentally left out from commit 923def9.
> >
> > Added:
> > list_free(relids_with_collist);
> >
> > Consistent with the existing:
> > list_free(relids_with_rf);
> >
>
> Okay since list_free for both relids and relids_with_rf are there, I
> think list_free for 'relids_with_rf' also make sense. So LGTM.
>
> thanks
> Shveta
>
>

This is a great find, LGTM!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-07-29 04:35:39 Re: Missing list_free in publicationcmds.c:OpenTableList
Previous Message Peter Smith 2026-07-29 04:22:53 Re: A new C function `get_partition_root`.