| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Subject: | Re: Follow-up review items for update_deleted |
| Date: | 2026-09-03 13:57:06 |
| Message-ID: | CAJpy0uA=EOSd9gv+-bq6HwyvD=uUct_wq3-VH8M2sJ68paD8cQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The patch 001 looks good to me. I had just one comment which I noticed
Kuroda-San has already covered.
ReplicationSlotMarkDirty();
ReplicationSlotSave();
These calls are only needed if xmin is adjusted.
--
Now, the better names for 'init_conflict_slot_xmin' could be:
adjust_conflict_slot_xmin, refresh_conflict_slot_xmin.
--
Also would it be better if we change elog to:
if (!TransactionIdIsValid(old_xmin))
elog(DEBUG1, "initialized conflict detection slot's xmin to %u", xmin_horizon);
else
elog(DEBUG1, "adjusted conflict detection slot's xmin from %u to %u",
old_xmin, xmin_horizon);
<Do it only if you find it better>
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-09-03 14:10:45 | FOR PORTION OF: BEFORE INSERT triggers can silently drop leftover rows? |
| Previous Message | Tom Lane | 2026-09-03 13:52:07 | Re: new clang warnings about unused global variables |