Re: new clang warnings about unused global variables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new clang warnings about unused global variables
Date: 2026-09-03 13:52:07
Message-ID: 1458243.1788443527@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I sense that nobody is going to have issues with this. Any objections
> to backpatching this? I suspect that over time many more people are
> going to run into this, so keeping the backbranches warning-free seems
> sensible.

Agreed, we usually like to keep the back branches warning-free too.

But I concur with Andreas that 0005 looks a bit half-baked.
Maybe that's the right amount of effort for the back branches,
but something else should happen in HEAD.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-09-03 13:57:06 Re: Follow-up review items for update_deleted
Previous Message Fujii Masao 2026-09-03 13:50:52 Re: REPACK (ANALYZE) within transaction block segfaults