| From: | Matheus de Oliveira <matioli(dot)matheus(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, José Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT |
| Date: | 2020-03-29 14:39:25 |
| Message-ID: | CAJghg4+hcKC2RQhZBgAWmg+=+JWxShtw_WgXRN1x0rFU39C5SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi All,
I've took some time today to rebase the patch with master. Follows attached.
I'm still not sure if the chosen path is the best way. But I'd be glad to
follow any directions we all see fit.
For now, this patch applies two methods:
1. Changes full constraint definition (which keeps compatibility with
current ALTER CONSTRAINT):
ALTER CONSTRAINT [<on_update>] [<on_delete>] [<deferrability>]
2. Changes only the subset explicit seem in the command (a new way, I've
chosen to just add SET in the middle, similar to `ALTER COLUMN ... SET
{DEFAULT | NOT NULL}` ):
ALTER CONSTRAINT SET [<on_update>] [<on_delete>] [<deferrability>]
I'm OK with changing the approach, we just need to chose the color :D
I believe this is a small change in source code, but with huge impact for
users with big tables. Would be great if it could go in PG 13.
Best regards,
--
Matheus de Oliveira
| Attachment | Content-Type | Size |
|---|---|---|
| postgresql-alter-constraint.v8.patch | text/x-patch | 32.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-03-29 15:27:36 | Re: PATCH: add support for IN and @> in functional-dependency statistics use |
| Previous Message | James Coleman | 2020-03-29 14:21:06 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |