Re: Parallel INSERT (INTO ... SELECT ...)

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel INSERT (INTO ... SELECT ...)
Date: 2020-10-12 01:44:24
Message-ID: CAJcOf-dKsm3H-uB9NYN73yt51w7M7+7DOcaM2AmwbPBhaZN34A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Oct 11, 2020 at 1:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Oct 10, 2020 at 5:25 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > 8. You have made changes related to trigger execution for Gather node,
> > don't we need similar changes for GatherMerge node?
> >
> ..
> >
> > 10. Don't we need a change similar to cost_gather in
> > cost_gather_merge? It seems you have made only partial changes for
> > GatherMerge node.
> >
>
> Please ignore these two comments as we can't push Insert to workers
> when GatherMerge is involved as a leader backend does the final phase
> (merge the results by workers). So, we can only push the Select part
> of the statement.
>

Precisely, that's why I didn't make those changes for GatherMerge.

Regards,
Greg Nancarrow
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message movead.li@highgo.ca 2020-10-12 01:46:37 Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Previous Message Ranier Vilela 2020-10-12 01:34:40 Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)