Windows build warnings

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Windows build warnings
Date: 2021-11-22 11:10:10
Message-ID: CAJcOf-c+KniGAp31pn8TC=9a-WHXpkX-3+8-2BkaCsZchhu=8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I'm seeing the following annoying build warnings on Windows (without
asserts, latest Postgres source):

pruneheap.c(858): warning C4101: 'htup': unreferenced local variable
pruneheap.c(870): warning C4101: 'tolp': unreferenced local variable

I notice that these are also reported here: [1]

I've attached a patch to fix these warnings.
(Note that currently PG_USED_FOR_ASSERTS_ONLY is defined as the unused
attribute, which is only supported by GCC)

[1]: https://www.postgresql.org/message-id/CAH2-WznwWU+9on9nZCnZtk7uA238MCTgPxYr1Ty7U_Msn5ZGwQ@mail.gmail.com

Regards,
Greg Nancarrow
Fujitsu Australia

Attachment Content-Type Size
fix_windows_build_warnings.patch application/octet-stream 913 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-11-22 11:17:30 Re: Windows build warnings
Previous Message Dilip Kumar 2021-11-22 11:05:19 Re: Replication & recovery_min_apply_delay