| From: | kedar anavardekar <kedar(dot)anavardekar(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Publication of same parent table with ONLY-ness mismatch should error |
| Date: | 2026-10-20 12:22:49 |
| Message-ID: | CAJZSXGqjWYZA5MswCR-E5B6fH_0f+BpLxocdZ0pEmQa89uPQ-Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> PSA patch v4.
Hi Peter,
Thank you for the patches,
I reviewed the patch v4 and these are minor points, so please feel
free to leave them out if you don’t think they’re necessary.
1. In the comment in publicationcmds.c,
typo :“explcitly” -> “explicitly.”
2. In publication.sql, CREATE TABLE tbl_plain(a int);;
has an extra semicolon.
3. Will adding the following test for tbl_plain be redundant?
CREATE PUBLICATION testpub_conflict5 FOR TABLE tbl_plain, ONLY tbl_plain;
CREATE PUBLICATION testpub_conflict6 FOR TABLE ONLY tbl_plain, tbl_plain;
Apart from these the patch LGTM.
Best,
Kedar
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Geier | 2026-10-20 12:31:56 | Re: Reducing relcache memory usage 2: shrink sizeof(RelationData) |
| Previous Message | Amit Langote | 2026-10-20 11:30:22 | Re: [PATCH] Fix segmentation fault caused by reentrancy in RI_Fkey_cascade_del (ri_triggers.c) |