Re: Publication of same parent table with ONLY-ness mismatch should error

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Publication of same parent table with ONLY-ness mismatch should error
Date: 2026-10-20 07:31:09
Message-ID: CAHut+PuB2FPErGppvCTS2CE1OJGFg56g3GjUrVcqWo0ZBynB2w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 20, 2026 at 2:30 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
...
>
> Should we also add tests for the EXCEPT clause, as it touches EXCEPT?
>
> postgres=# create publication pub1 for all tables except(table only
> testpub_tbl_parent, testpub_tbl_parent);
> ERROR: conflicting ONLY specifications for table "testpub_tbl_parent"
>

I think having EXCEPT tests for ONLY-ness mismatch will execute the
same internal logic (OpenTableList) that is already being tested.

I've added a few EXCEPT tests just for completeness. To make them a
bit different, they are using ALTER PUBLICATION.

PSA patch v4.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v4-0001-Error-if-same-table-has-ONLY-mismatch.patch application/octet-stream 14.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Manu 2026-10-20 07:37:55 Re: Parallel Apply
Previous Message David Geier 2026-10-20 07:27:57 Re: Improving scalability of Parallel Bitmap Heap/Index Scan