| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Clean up property graph error messages |
| Date: | 2026-05-07 09:04:05 |
| Message-ID: | CAJTYsWWGfGmdbKAet5jj326ik6zbKivtn9KBfFxB9uLNLuk6yA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 7 May 2026 at 14:15, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> > and moves a
> > ReleaseSysCache() call before an ERROR ereport in
> > check_element_properties().
> >
> > The existing code should be cleaned up by
> > the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> > placed after ereport(ERROR) was unreachable.
>
> I think that's fine. I don't think the change makes this better.
>
IIUC that is dead code right now, it never reaches that point to release?
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-05-07 09:09:36 | Re: Server crash: Use-after-free in AfterTriggerEndQuery() |
| Previous Message | Peter Eisentraut | 2026-05-07 09:00:48 | Re: Fix DROP PROPERTY GRAPH "unsupported object class" error |