| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Clean up property graph error messages |
| Date: | 2026-05-07 08:45:13 |
| Message-ID: | 459ea164-aa38-43dd-8c93-dbb1063d20b5@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04.05.26 21:57, Ayush Tiwari wrote:
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
>
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names",
I have fixed that.
> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().
>
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.
I think that's fine. I don't think the change makes this better.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-05-07 08:46:04 | Re: [PATCH] Clean up property graph error messages |
| Previous Message | Jim Jones | 2026-05-07 08:43:01 | Re: Fix bug with accessing to temporary tables of other sessions |