Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl
Date: 2026-09-04 04:56:29
Message-ID: CAJTYsWUNRGZBy+cvXRN4srzm98kfjM7W_HVJbFRzryABp-Fuew@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 4 Sept 2026 at 09:30, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> Hello Ayush and Fujii-san,
>
> 04.09.2026 06:07, Fujii Masao wrote:
> > On Fri, Sep 4, 2026 at 6:48 AM Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
wrote:
> >> Thoughts?
> > Thanks for the patches! They look good to me.
>
> Thank you for paying attention to my reports!
>
> I'm not sure about the autovacuum fix -- I've found that I tried the same
> targeted autovacuum = false as Melanie proposed back then ([1]) and the
> test still failed. Please let me recheck carefully if it's still an issue.
>
> Regarding v1-0001, I've tested it with the repro.patch applied and
> confirmed it works. Thank you!
>
> [1]
https://www.postgresql.org/message-id/714729ea-f536-0faf-353b-cbd5c8f241ea%40gmail.com

Thanks for testing and confirming 0001.

One detail I noticed in [1] is that the posted change sets
autovacuum_enabled=false on the initial table. That table is later dropped
and recreated for the recovery deadlock test, so the reloption does not
carry over. 0002 sets it on the recreated table instead.

However, if you tested that placement as well, there may be another race.

Regards,
Ayush

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-09-04 04:58:55 Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator
Previous Message Paul A Jungwirth 2026-09-04 04:53:08 FOR PORTION OF elog on non-polymorphic opcintype