| From: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: MERGE SQL statement for PG12 |
| Date: | 2018-09-29 21:25:37 |
| Message-ID: | CAJGNTeP3NGjA3iWUZY2WtX9N-vDg0H589yyXqM_j0CcWzUsjEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 24 Sep 2018 at 05:15, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> wrote:
>
> A new version rebased against the current master is attached.
>
Hi Pavan,
A day after you posted this patch commit
29c94e03c7d05d2b29afa1de32795ce178531246 removed ExecStoreTuple.
I'm right in believe that the change in
src/backend/executor/execMerge.c should be for ExecStoreHeapTuples?
- ExecStoreTuple(&tuple, mtstate->mt_existing, buffer, false);
+ ExecStoreHeapTuple(&tuple, mtstate->mt_existing, false);
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Kornilov | 2018-09-29 21:29:40 | Re: Continue work on changes to recovery.conf API |
| Previous Message | Tom Lane | 2018-09-29 20:06:46 | Re: Cygwin linking rules |