| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-07-12 10:10:39 |
| Message-ID: | CAJ7c6TPsg6iUGZGaEGKi5vdG6VpEcLyZMbXTUQFnCNdi+Kd00Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
> The "safety check: do not allow toasted storage modes unless column
> datatype is TOAST-aware" could be moved into GetAttributeStorage(), so
> it doesn't have to be repeated. (Note that GetAttributeCompression()
> does similar checking.)
Good point. Fixed.
> ATExecSetStorage() currently doesn't do any such check, and your patch
> isn't adding one. Is there a reason for that?
ATExecSetStorage() does this, but the check is a bit below [1]. In v7
I moved the check to GetAttributeStorage() as well.
[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/tablecmds.c#l8312
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Allow-specifying-STORAGE-attribute-for-a-new-tabl.patch | application/octet-stream | 19.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Malakhov | 2022-07-12 10:25:43 | Re: [PATCH] Compression dictionaries for JSONB |
| Previous Message | vignesh C | 2022-07-12 09:28:04 | Re: Handle infinite recursion in logical replication setup |