| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-07-11 13:17:13 |
| Message-ID: | d3cb9b64-0665-4e72-329f-b4c10f6faff3@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.07.22 11:27, Aleksander Alekseev wrote:
>>> Here is a patch updated according to all the recent feedback, except
>>> for two suggestions:
>>
>> In v4 I forgot to list possible arguments for STORAGE in
>> alter_table.sgml, similarly as it is done for other subcommands. Here
>> is a corrected patch.
>
> Here is the rebased patch.
The "safety check: do not allow toasted storage modes unless column
datatype is TOAST-aware" could be moved into GetAttributeStorage(), so
it doesn't have to be repeated. (Note that GetAttributeCompression()
does similar checking.)
ATExecSetStorage() currently doesn't do any such check, and your patch
isn't adding one. Is there a reason for that?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2022-07-11 13:19:39 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Robert Haas | 2022-07-11 13:16:30 | Re: pg15b2: large objects lost on upgrade |