| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Several refactorings for pg_dump |
| Date: | 2026-08-18 15:10:45 |
| Message-ID: | CAJ7c6TPqLZOMk3hPrgLQvrOg9BCY4SV6bUC_wx54fyquRkBckw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While examining pg_dump code I found some room for improvement:
1. I found a write-only field ArchiveHandle.lookaheadSize which can
safely be removed.
2. I found magic constants 512 which should be replaced with TAR_BLOCK_SIZE.
Patches are attached.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-pg_dump-remove-unused-ArchiveHandle.lookaheadSize.patch | text/x-patch | 1.9 KB |
| v1-0002-pg_dump-use-TAR_BLOCK_SIZE-instead-of-a-hardcoded.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-08-18 15:17:33 | Re: Residual cleanups for tied objects in PL/Perl |
| Previous Message | Noah Misch | 2026-08-18 15:09:01 | Re: PG19 FK fast path: OOB write and missed FK checks during batched |