| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Andrey Borodin <amborodin(at)acm(dot)org>, Kirk Wolak <wolakk(at)gmail(dot)com> |
| Subject: | Re: PG19 FK fast path: OOB write and missed FK checks during batched |
| Date: | 2026-08-18 15:09:01 |
| Message-ID: | 20260818150901.a3.noahmisch@microsoft.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 18, 2026 at 10:42:14PM +0900, Amit Langote wrote:
> After considering Peter's report of another bug [1] that is fixed by
> 0001, I tested both his reproducer and nested firing involving the
> same constraint.
>
> The latter exposed a problem in v1: the cache was still keyed only by
> constraint OID, so a nested check of the same constraint reused the
> outer entry and did not register a callback at the nested query depth.
> In v2, the key is now (constraint OID, query depth), giving each
> firing level its own entry and callback.
>
> 0001 now includes regression tests for both cases. 0002 and 0003 are unchanged.
>
> I would like to commit these sometime this week and would appreciate a review.
I won't be able to review this. The list should consider it up for grabs.
> [1] https://postgr.es/m/CAH2-Wz%3DD533JbF_ak_Pc8kP0FKse-ju8DnMxtjvY%3D%3DyHsP4xgw%40mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2026-08-18 15:10:45 | [PATCH] Several refactorings for pg_dump |
| Previous Message | Bruce Momjian | 2026-08-18 14:44:20 | Re: First draft of PG 19 release notes |