[PATCH] Use role name "system_user" instead of "user" for unsafe_tests

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Date: 2023-04-11 18:25:30
Message-ID: CAJ7c6TPf81bH=pkoYxnNarCABNmJUMfZfN-RwxUNWdVRSywXWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While playing with a new single board computer (VisionFive 2) I
discovered that postgresql:unsafe_tests suite fails like this:

```
--- /home/user/projects/postgresql/src/test/modules/unsafe_tests/expected/rolenames.out
2023-04-11 14:58:57.844550612 +0000
+++ /home/user/projects/postgresql/build/testrun/unsafe_tests/regress/results/rolenames.out
2023-04-11 17:54:22.999024391 +0000
@@ -53,6 +53,7 @@
CREATE ROLE "current_user";
CREATE ROLE "session_user";
CREATE ROLE "user";
+ERROR: role "user" already exists
RESET client_min_messages;
CREATE ROLE current_user; -- error
ERROR: CURRENT_USER cannot be used as a role name here
@@ -1089,4 +1090,5 @@
DROP OWNED BY regress_testrol0, "Public", "current_role",
"current_user", regress_testrol1, regress_testrol2, regress_testrolx
CASCADE;
DROP ROLE regress_testrol0, regress_testrol1, regress_testrol2,
regress_testrolx;
DROP ROLE "Public", "None", "current_role", "current_user",
"session_user", "user";
+ERROR: current user cannot be dropped
DROP ROLE regress_role_haspriv, regress_role_nopriv;
```

This happens because the developers of this SBC choose the default
username "user", which I had no reason to change.

Test merely checks that we can distinguish a username "user" from the
USER keyword. Maybe it's worth replacing "user" with "system_user"? It
is also a keyword but is a less likely choice for the OS user name.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v1-0001-Use-role-name-system_user-instead-of-user-for-uns.patch application/octet-stream 2.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2023-04-11 18:36:01 Issue in postgres_fdw causing unnecessary wait for cancel request reply
Previous Message Andres Freund 2023-04-11 18:20:10 Re: Should we remove vacuum_defer_cleanup_age?