Re: [PATCH] Remove unused #include's in src/backend/commands/*

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: [PATCH] Remove unused #include's in src/backend/commands/*
Date: 2025-10-09 10:21:57
Message-ID: CAJ7c6TP_aD+HhH84SHu-cb_39qYtpyDQ7jQ7Dz4KAB-tPs7rWw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> > Why not use IWYU as recommended in src/tools/pginclude/README? I gave that
> > a try and it didn't take very long for src/.
>
> I've not rechecked today, but the last time I did, iwyu needed a lot of adult
> supervision with the current amount of annotations. If we did all the
> necessary annotations and caught up with all the things it suggests it should
> be easier, but as-is it's imo just usable as an idea-giver for manually
> written patches.

OK, I tried include-what-you-use with a little post-processing script
and the scope of work seems reasonable. I will submit the updated
patch shortly.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ls7777 2025-10-09 10:24:33 Re: Patch for migration of the pg_commit_ts directory
Previous Message vignesh C 2025-10-09 09:37:55 Re: Logical Replication of sequences