Re: [PATCH] Remove unused #include's in src/backend/commands/*

Hi,

On 2025-10-08 16:31:13 -0500, Nathan Bossart wrote:
> On Wed, Oct 08, 2025 at 09:41:30PM +0300, Aleksander Alekseev wrote:
> > The main problem here is that clangd is a language server, which means
> > I see errors reported by it when I open a particular file in a text
> > editor. To go manually over ~2500 .c/.h files we have and then see
> > what will break on CI because of an #ifdef (as it was with the patch
> > v1) doesn't strike me as a great idea :)
>
> Why not use IWYU as recommended in src/tools/pginclude/README? I gave that
> a try and it didn't take very long for src/.

I've not rechecked today, but the last time I did, iwyu needed a lot of adult
supervision with the current amount of annotations. If we did all the
necessary annotations and caught up with all the things it suggests it should
be easier, but as-is it's imo just usable as an idea-giver for manually
written patches.

Greetings,

Andres Freund