| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const to values and nulls arguments |
| Date: | 2023-10-10 09:14:26 |
| Message-ID: | CAJ7c6TNfoqnJYt8_bypgLYRMbVHjVxA9GRaYoJPn-uqEx99w=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> >> The 0002 patch, which I'm not proposing to commit at this time, makes
> >> similar changes but in a way that breaks the table and index AM APIs.
> >> So I'm just including that here in case anyone wonders, why didn't you
> >> touch those. And also maybe if we ever change that API incompatibly we
> >> could throw this one in then.
> >
> > 0001 looks good to me and passes the tests in several environments,
> > not surprisingly. Let's merge it.
>
> done
Great. FWIW changing the index AM API in this particular aspect
doesn't strike me as such a terrible idea.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2023-10-10 09:43:48 | Re: Retire has_multiple_baserels() |
| Previous Message | David Rowley | 2023-10-10 09:10:12 | Re: Check each of base restriction clauses for constant-FALSE-or-NULL |