| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const to values and nulls arguments |
| Date: | 2023-10-10 05:57:00 |
| Message-ID: | 69593f41-546f-4e45-bdd7-8f8a8d61386c@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.10.23 16:51, Aleksander Alekseev wrote:
>> There are a lot of Datum *values, bool *nulls argument pairs that should
>> really be const. The 0001 patch makes those changes. Some of these
>> hunks depend on each other.
>>
>> The 0002 patch, which I'm not proposing to commit at this time, makes
>> similar changes but in a way that breaks the table and index AM APIs.
>> So I'm just including that here in case anyone wonders, why didn't you
>> touch those. And also maybe if we ever change that API incompatibly we
>> could throw this one in then.
>
> 0001 looks good to me and passes the tests in several environments,
> not surprisingly. Let's merge it.
done
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nishant Sharma | 2023-10-10 05:57:14 | Re: [Code Cleanup] : Small code cleanup in twophase.sql |
| Previous Message | Richard Guo | 2023-10-10 05:50:15 | Re: Crash in add_paths_to_append_rel |