Re: [PATCH] Remove unused PageIsPredicateLocked()

Hi,

Thanks for the attention to the patch.

> > The patch looks good to me as well. Barring any objections, I will
> > commit it.
>
> BTW, while removing PageIsPredicateLocked(), I found that the
> "INTERFACE ROUTINES" comment in predicate.c is outdated. For example,
> it lists RegisterPredicateLockingXid(void), although the function takes
> a TransactionId, and omits functions such as
> CheckForSerializableConflictOutNeeded() and ShareSerializableXact().
>
> Rather than updating the list, isn't it better to remove it? The declarations
> are already available in the headers predicate.h, and maintaining
> a duplicate list seems likely to result in further omissions and
> outdated signatures.
>
> Thought?

Sounds good to me.

--
Best regards,
Aleksander Alekseev