Re: [DEPARSE] EXPLAIN prints another ModifyTable's RETURNING aliases in a SubPlan

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: assam258(at)gmail(dot)com, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] EXPLAIN prints another ModifyTable's RETURNING aliases in a SubPlan
Date: 2026-10-23 14:10:49
Message-ID: 2893902.1792764649@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> Not changing the rewriter does at least give ruleutils a chance to
> output something more useful in the weird edge cases, but as you say,
> I don't think it's worth focussing too much on such cases. The
> simplest fix is to just remove the Assert()s in get_variable(). The
> second simplest fix is to replace them with refname = "old"/"new", if
> it's NULL, which I think is slightly better in some of the weird edge
> cases, though I'd be happy with either fix.

I'm content to remove the Asserts.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Prashant Kumar 2026-10-23 14:30:17 [PATCH] pgcrypto: Fix sha-crypt rounds= values that do not fit in int (BUG #19743)
Previous Message Aleksander Alekseev 2026-10-23 13:42:38 Re: [PATCH] Remove unused PageIsPredicateLocked()