Re: {heap,minimal}_expand_tuple() are unused

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: {heap,minimal}_expand_tuple() are unused
Date: 2026-09-09 14:54:24
Message-ID: CAJ7c6TMivPQhYf8y1sojpXuZ4kO7Ktfr=sFmMFBMs3aveqYtOQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Andres Freund <andres(at)anarazel(dot)de> writes:
> >> Both heap_expand_tuple() and minimal_expand_tuple() being unused, make
> >> expand_tuple() unused in turn.
> >> I think we probably ought to remove all three in 20? I didn't find external
> >> callers. It's nontrivial enough code that I don't think we should keep it
> >> around just because somebody might be using it.
>
> ... BTW, upon looking at the code coverage report to confirm these
> are unused, I noticed that the adjacent heap_copytuple_with_tuple is
> also unreferenced.

Today I re-discovered this fact and recalled this discussion. Here is
the patch in case it will speed-up things.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v1-0001-Remove-unused-tuple-expansion-and-copying-functio.patch text/x-patch 11.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Geier 2026-09-09 14:59:54 Re: Add pg_stat_vfdcache view for VFD cache statistics
Previous Message Tom Lane 2026-09-09 14:54:18 Re: remove_useless_joins vs. bug #19560