Re: --enable-{debug,cassert} should also activate --enable-depend

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Dimitrios Apostolou <jimis(at)gmx(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: --enable-{debug,cassert} should also activate --enable-depend
Date: 2025-06-17 13:04:09
Message-ID: CAJ7c6TM-=ms1=NFk64hiKVyQcX2+ObDz3nSWjtcmc3DwxL2q3Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Dimitris,

> I just spent 2 miserable days tracking down a very weird issue. I ended up
> stepping through the code in the debugger. As it turned out, the very same
> moment of execution, one datastructure (struct _restoreOptions defined in
> pg_backup.h) contained different fields on one data frame than another!
> This was the result of one object file *not* being re-compiled as needed,
> after applying my patch that added that extra field to the datastructure
> in pg_backup.h.
>
> This caused weird and completely irrelevant failures, as unexpected fields
> of the struct were changing value.
>
> I then found that I need to compile with --enable-depend to have Makefiles
> with proper dependency tracking. Shouldn't it be the default, at least for
> non-release builds?

I sympathize but realistically I doubt that someone is going to do
something about it. Autotools slowly approaches its end of life and
for Meson we don't seem to have an equivalent of --enable-depend. On
top of that I imagine how one could argue that these options should be
independent.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2025-06-17 13:09:00 Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)
Previous Message jian he 2025-06-17 12:55:45 Re: wrong comments in rewriteTargetListIU