--enable-{debug,cassert} should also activate --enable-depend

From: Dimitrios Apostolou <jimis(at)gmx(dot)net>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: --enable-{debug,cassert} should also activate --enable-depend
Date: 2025-06-17 12:32:48
Message-ID: 7cc2b798-4ee4-181c-29cd-f67c22c45da1@gmx.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello list,

I just spent 2 miserable days tracking down a very weird issue. I ended up
stepping through the code in the debugger. As it turned out, the very same
moment of execution, one datastructure (struct _restoreOptions defined in
pg_backup.h) contained different fields on one data frame than another!
This was the result of one object file *not* being re-compiled as needed,
after applying my patch that added that extra field to the datastructure
in pg_backup.h.

This caused weird and completely irrelevant failures, as unexpected fields
of the struct were changing value.

I then found that I need to compile with --enable-depend to have Makefiles
with proper dependency tracking. Shouldn't it be the default, at least for
non-release builds?

Thanks,
Dimitris

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2025-06-17 12:34:48 Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c)
Previous Message Rahila Syed 2025-06-17 12:13:24 Re: add function for creating/attaching hash table in DSM registry