| From: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Pluggable Storage - Andres's take |
| Date: | 2019-01-15 09:52:17 |
| Message-ID: | CAJ3gD9dfG-=cjqJaOHHOefihFRtMYHMKKg897T5ARVAp1OkQwg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 15 Jan 2019 at 12:27, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
>
> > On Mon, Jan 14, 2019 at 2:07 PM Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> >
> > createPQExpBuffer() should be moved after the below statement, so that
> > it does not leak memory
>
> Thanks for noticing, fixed.
Looks good.
>
> > So how about bumping up the archive version and doing these checks ?
>
> Yeah, you're right, I've added this check.
Need to bump K_VERS_MINOR as well.
On Mon, 14 Jan 2019 at 18:36, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> +static void _selectTableAccessMethod(ArchiveHandle *AH, const char
> *tablespace);
> tablespace => tableam
This is yet to be addressed.
--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrien NAYRAT | 2019-01-15 10:05:16 | Re: Log a sample of transactions |
| Previous Message | Pavel Stehule | 2019-01-15 09:50:25 | Re: regress tests fails |