Re: Improving display of octal GUCs

Hi,

> regression=# SELECT name,setting,min_val,max_val,boot_val,reset_val
> FROM pg_settings
> WHERE name IN ('data_directory_mode', 'log_file_mode',
'unix_socket_permissions');
> name | setting | min_val | max_val | boot_val |
reset_val
>
-------------------------+---------+---------+---------+----------+-----------
> data_directory_mode | 0700 | 0000 | 0777 | 0700 | 0700
> log_file_mode | 0600 | 0000 | 0777 | 0600 | 0600
> unix_socket_permissions | 0777 | 0000 | 0777 | 0777 | 0777
> (3 rows)
>
> Details in the draft commit message.
>
I tested the patch locally and found no functional issue. LGTM.

One minor note: I considered whether check_GUC_init() should
validate GUC_SHOW_IN_OCTAL (e.g. not allowing it together with a
show_hook, or with other flags). But some GUCs intentionally use a
show_hook, and check_GUC_init() validates only a few combinations
today, so I don't think it's necessary here.

Regards,
Tatsuya Kawata