Re: Improving display of octal GUCs

Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> writes:
> One minor note: I considered whether check_GUC_init() should
> validate GUC_SHOW_IN_OCTAL (e.g. not allowing it together with a
> show_hook, or with other flags). But some GUCs intentionally use a
> show_hook, and check_GUC_init() validates only a few combinations
> today, so I don't think it's necessary here.

Yeah, I think there actually could be a use-case for having a
show_hook along with GUC_SHOW_IN_OCTAL: if you want the value shown in
octal but the calculation of the effective value is more complicated
than just "show the variable". So I don't want to reject that.
Perhaps there's a case for checking that GUC_SHOW_IN_OCTAL isn't
applied to a non-integer GUC, but I can't get too excited about that.

regards, tom lane