| From: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE |
| Date: | 2025-12-23 13:20:08 |
| Message-ID: | CAHza6qd2AUfezWX3HNEqop7-Na2GCMy4GgRJOu1LtvYCc5ha-A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Sawada-san and Chao-san,
Thank you both for your continued reviews and feedback on this patch.
> The patch mostly looks good to me. I've made some cosmetic changes to
> the comments (as well as the commit message) and attached the updated
> patch. Please review it.
Thank you. I have no objections.
> My last nitpick on v9:
>
> ```
> + appendStringInfo(&buf,
> +
ngettext("memory usage: %.2f MB in total, with dead-item storage reset %d
time (limit was %.2f MB)\n",
> +
"memory usage: %.2f MB in total, with dead-item storage reset %d times
(limit was %.2f MB)\n",
> ```
>
> Instead of “dead-item”, I would suggest “dead item” (without dash),
because in the existing code use “dead item”, for example:
>
> ```
I've addressed your feedback.
Attached is v10 with these changes incorporated.
I really appreciate reviewing this patch throughout the iterations.
Regards,
Tatsuya Kawata
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Add-dead-items-memory-usage-to-VACUUM-VERBOSE-an.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2025-12-23 13:26:54 | Re: Row pattern recognition |
| Previous Message | Peter Eisentraut | 2025-12-23 13:15:09 | Change some Datum to void * for opaque pass-through pointer |