| From: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [Patch]Add tab completion for DELETE ... USING |
| Date: | 2025-12-27 00:49:48 |
| Message-ID: | CAHza6qcrk0EoCYmaYpQkiVKpjb9JGFsPt=v-uWQeLQHbg6K=LA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao-san,
Thank you very much for your review!
> Firs the first case:
> ```
> +# check DELETE ... USING completion
> +check_completion(
> + "DELETE FROM tab1 USING my\t",
> + qr/mytab/,
> + "complete DELETE FROM tab USING with table name");
> ```
>
> Maybe just say “with tab”, because the rest test cases’ messages all say
“USING tab”.
I fixed it as you mentioned.
The updated v2 is attached.
Regards,
Tatsuya Kawata
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-tab-completion-for-DELETE-USING.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2025-12-27 01:30:51 | Re: Run perltidy on src/test/perl/PostgreSQL/Test/Cluster.pm |
| Previous Message | Michael Paquier | 2025-12-26 23:33:39 | Re: Run perltidy on src/test/perl/PostgreSQL/Test/Cluster.pm |