| From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Request for comment on setting binary format output per session |
| Date: | 2023-04-24 23:18:34 |
| Message-ID: | CAHyXU0z1P5oikjxQ6wJYEHGEOuiRrv+=XsjHg=o1a6TFLn53Gg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 20, 2023 at 2:52 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
> As promised here is a patch with defines for all of the protocol messages.
>
I created a protocol.h file and put it in src/includes
> I'm fairly sure that some of the names I used may need to be changed but
> the grunt work of finding and replacing everything is done.
>
In many cases, converting inline character to macro eliminates the need for
inline comment, e.g.:
+ case SIMPLE_QUERY: /* simple query */
...that's more work obviously, do you agree and if so would you like some
help going through that?
merlin
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2023-04-24 23:20:30 | Re: pg_stat_io not tracking smgrwriteback() is confusing |
| Previous Message | Melanie Plageman | 2023-04-24 23:02:47 | Re: pg_stat_io not tracking smgrwriteback() is confusing |