| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Request for comment on setting binary format output per session |
| Date: | 2023-04-25 11:26:18 |
| Message-ID: | CADK3HHKbWEnbY07OAh1wuSr8HYSx-mYuUTCsit6DMFeEZSaeew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 24 Apr 2023 at 19:18, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>
>
> On Thu, Apr 20, 2023 at 2:52 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
>>
>> As promised here is a patch with defines for all of the protocol messages.
>>
> I created a protocol.h file and put it in src/includes
>> I'm fairly sure that some of the names I used may need to be changed but
>> the grunt work of finding and replacing everything is done.
>>
>
> In many cases, converting inline character to macro eliminates the need
> for inline comment, e.g.:
> + case SIMPLE_QUERY: /* simple query */
>
> ...that's more work obviously, do you agree and if so would you like some
> help going through that?
>
I certainly agree. I left them there mostly for reviewers. I expected some
minor adjustments to names of the macro's
So if you have suggestions I'll make changes.
I'll remove the comments if they are no longer necessary.
Dave
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-04-25 12:39:39 | Re: Should vacuum process config file reload more often |
| Previous Message | Peter Eisentraut | 2023-04-25 10:27:52 | Re: ssl tests aren't concurrency safe due to get_free_port() |