Re: Add support for specifying tables in pg_createsubscriber.

On Sun, Oct 12, 2025 at 4:25 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham,
>
> Here are some v15 review comments.
>
> ======
> IIUC the test cases #3 and #4 are supposed to reuse an existing publication.
>
> There is logging in the code:
> + /* Reuse existing publication on publisher. */
> + pg_log_info("use existing publication \"%s\" in database \"%s\"",
> + dbinfo[i].pubname, dbinfo[i].dbname);
>
> But I do not see those logs appearing anywhere in the test results.
>
> I think this is caused by a simple mismatch in your test script
> between the pub names in the db versus the pub names you are using in
> those test commands.
>

Hi Peter,

You are correct — the issue was due to a mismatch between the
publication names used in the databases and those referenced in the
test commands for cases #3 and #4. I’ve corrected the test script, and
the expected “use existing publication ...” logs now appear as
intended.
I’ve attached the updated test script, captured logs, and the expected
log matrix for reference. The patch I used for these runs is also
available at [1].

[1] - https://www.postgresql.org/message-id/CAHv8RjJPCRwGs0tbLCi36W6rKdUWQmLCtp6G%3D3YVQVCkO_B8QA%40mail.gmail.com

Thanks and regards,
Shubham Khanna.