| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add support for specifying tables in pg_createsubscriber. |
| Date: | 2025-10-11 22:55:07 |
| Message-ID: | CAHut+PuyA9LcFvqco1WLxzVBKC3qCouQ1YUeUSBqNfudDGOP9A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shubham,
Here are some v15 review comments.
======
IIUC the test cases #3 and #4 are supposed to reuse an existing publication.
There is logging in the code:
+ /* Reuse existing publication on publisher. */
+ pg_log_info("use existing publication \"%s\" in database \"%s\"",
+ dbinfo[i].pubname, dbinfo[i].dbname);
But I do not see those logs appearing anywhere in the test results.
I think this is caused by a simple mismatch in your test script
between the pub names in the db versus the pub names you are using in
those test commands.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-10-12 00:42:30 | Re: GNU/Hurd portability patches |
| Previous Message | Álvaro Herrera | 2025-10-11 14:48:44 | Re: memory leak in dbase_redo() |