| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2021-08-01 10:21:21 |
| Message-ID: | CAHut+PvgRDs8NoPA2n7FwpctW1-9S-=BH6H9Dcpq1udPnh2o3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 1, 2021 at 3:05 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > > Here, the test is expecting 2 prepared transactions corresponding to
> > > two subscriptions but it waits for just one subscription via
> > > appname_copy. It should wait for the second subscription using
> > > $appname as well.
> > >
> > > What do you think?
> >
> > I agree with this analysis. The test needs to wait for both
> > subscriptions to catch up.
> > Attached is a patch that addresses this issue.
>
> The changes look good to me.
>
The patch to the test code posted by Ajin LGTM also.
I applied the patch and re-ran the TAP subscription tests. All OK.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-08-01 10:40:58 | Re: Corrected documentation of data type for the logical replication message formats. |
| Previous Message | Heikki Linnakangas | 2021-08-01 09:49:19 | Re: Split xlog.c |