| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhong950419(at)gmail(dot)com" <zhong950419(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Missing list_free in publicationcmds.c:OpenTableList |
| Date: | 2026-08-12 22:23:21 |
| Message-ID: | CAHut+PvaatLRJFMmf63=CophL2g6=k_+3-ZDHmavNg4bcvnHLg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 12, 2026 at 9:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Aug 11, 2026 at 6:06 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> > > On 11 Aug 2026, at 04:27, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Tue, Aug 11, 2026 at 4:51 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >>
> > >> Fair enough. TBH I'm not sure if comments like this are usual
> > >> practice,
> > >
> > > Yes, I have a similar understanding so let's not set a precedent that
> > > could invite similar comments sprinkled everywhere a list_free/pfree
> > > is not called, which is noise rather than signal.
> >
> > A very big +1 on that.
> >
>
> Pushed.
>
Thanks for pushing.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-08-12 22:32:41 | Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG |
| Previous Message | Zsolt Parragi | 2026-08-12 22:18:16 | Re: [PATCH] Fix PITR pause bypass when initial XLOG_RUNNING_XACTS has subxid overflow |