Re: Missing list_free in publicationcmds.c:OpenTableList

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhong950419(at)gmail(dot)com" <zhong950419(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Missing list_free in publicationcmds.c:OpenTableList
Date: 2026-08-12 11:57:08
Message-ID: CAA4eK1KuV6-+F6872enw5=WsjSB7YTdnt1EUsqK4_yMUQ1UM+A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 11, 2026 at 6:06 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 11 Aug 2026, at 04:27, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Aug 11, 2026 at 4:51 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >>
> >> Fair enough. TBH I'm not sure if comments like this are usual
> >> practice,
> >
> > Yes, I have a similar understanding so let's not set a precedent that
> > could invite similar comments sprinkled everywhere a list_free/pfree
> > is not called, which is noise rather than signal.
>
> A very big +1 on that.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2026-08-12 12:01:26 Re: Fix small psql slash option leaks
Previous Message Bertrand Drouvot 2026-08-12 11:52:16 Re: Split index and table statistics into different types of stats