| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - Add missing EXCEPT parameter description to ALTER PUBLICATION |
| Date: | 2026-06-11 00:36:22 |
| Message-ID: | CAHut+PvMRM4gQ0fHUMfJJN60Trq0-EscTyoT20MLfEmPdry1jQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 10, 2026 at 9:17 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jun 9, 2026 at 10:12 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > As Peter noted in [1], the ALTER PUBLICATION documentation is missing
> > a parameter description for the EXCEPT clause. Ref: Commit fd36606
> > introduced the EXCEPT clause.
> >
>
> But, we also don't have an explanation for SET { publication_object [,
> ...] | publication_all_object ..} for which EXCEPT is a sub-command.
> So what justifies to add a separate explanation for EXCEPT in ALTER
> PUBLICATION docs?
>
If not here, then the information about would have to be added in the
"Description" part instead. Yes, maybe that is OK for now.
I think this patch is also anticipating the other EXCEPT enhancements
"FOR ALL SEQUENCES EXCEPT..." [1] and "FOR TABLES IN SCHEMA EXCEPT..."
[2]. Those will also want to document special notes about altering
exclusions. Putting all those exclusion notes in the "Description"
part would cause too much clutter IMO. So this patch is just giving a
place for those other threads to put their notes today, instead of
requiring churning everything to introduce an "EXCEPT" part later
anyway.
======
[1] https://www.postgresql.org/message-id/flat/CAHut%2BPt6O3YD8h61RCtzMrRwgvS%3DRDRNf4KuXAUn1WYnoFU_uQ%40mail.gmail.com#93e11754e3e1007489d8589e71262ffe
[2] https://www.postgresql.org/message-id/flat/CABdArM5sw4Q1ZU8HGdo4BSc1A_%2B8xtUNq17j6wcir%3DyMUy19Cg%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-06-11 00:49:47 | Re: Having problems generating a code coverage report |
| Previous Message | Fujii Masao | 2026-06-11 00:13:45 | Disable startup progress timeout during standby WAL replay |