| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - Add missing EXCEPT parameter description to ALTER PUBLICATION |
| Date: | 2026-06-11 02:58:03 |
| Message-ID: | CAA4eK1Jb=s3zqL5dT7FS=moZA=ynVOJqguNEgYJhv19oTajyLQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 11, 2026 at 6:06 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Jun 10, 2026 at 9:17 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jun 9, 2026 at 10:12 AM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > > As Peter noted in [1], the ALTER PUBLICATION documentation is missing
> > > a parameter description for the EXCEPT clause. Ref: Commit fd36606
> > > introduced the EXCEPT clause.
> > >
> >
> > But, we also don't have an explanation for SET { publication_object [,
> > ...] | publication_all_object ..} for which EXCEPT is a sub-command.
> > So what justifies to add a separate explanation for EXCEPT in ALTER
> > PUBLICATION docs?
> >
>
> If not here, then the information about would have to be added in the
> "Description" part instead. Yes, maybe that is OK for now.
>
I see that already information related to EXCEPT is present in the
Description section.
> I think this patch is also anticipating the other EXCEPT enhancements
> "FOR ALL SEQUENCES EXCEPT..." [1] and "FOR TABLES IN SCHEMA EXCEPT..."
> [2]. Those will also want to document special notes about altering
> exclusions. Putting all those exclusion notes in the "Description"
> part would cause too much clutter IMO.
>
Possible, but how to arrange that documentation is a separate
discussion. I feel we may want to point the links to the relevant
places in CREATE PUBLICATION.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2026-06-11 02:58:21 | Re: Disable startup progress timeout during standby WAL replay |
| Previous Message | torikoshia | 2026-06-11 02:27:20 | Re: Why is the LSN reported for pg_logical_emit_message() different from other decoded operations? |