| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+ |
| Date: | 2026-04-20 02:56:40 |
| Message-ID: | CAHut+Puic9YTrdj3B4BX1J-m=EJTtF5bhxk8cJpKJVrw6QWMLA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 17, 2026 at 3:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Apr 17, 2026 at 4:34 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Fri, Apr 17, 2026 at 12:10 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > >
> > > On 2026-Apr-10, Peter Smith wrote:
> > >
> > > > # -- describe the tables
> > > > # \d t1
> > > > Table "public.t1"
> > > > Column | Type | Collation | Nullable | Default
> > > > --------+---------+-----------+----------+---------
> > > > a | integer | | |
> > > > Except Publications:
> > > > "pub1"
> > >
> > > I have a hard time understanding what an "except publication" is. I
> > > think this would be clearer if the header said "Excluded from publications:"
> > >
> >
> > I agree that your suggestion is clearer.
> >
> > If we make that change, then should the "Publications:" footer also be
> > modified similarly (to "Included in publications:") so they match?
> >
> > e.g.
> >
> > CURRENTLY
> >
> > test_pub=# \d t1
> > Table "public.t1"
> > Column | Type | Collation | Nullable | Default
> > --------+---------+-----------+----------+---------
> > a | integer | | |
> > Publications:
> > "pub1"
> > "pub2"
> > Except publications:
> > "pub3"
> >
> > ~~~
> >
> > SUGGESTION
> >
> > test_pub=# \d t1
> > Table "public.t1"
> > Column | Type | Collation | Nullable | Default
> > --------+---------+-----------+----------+---------
> > a | integer | | |
> > Included in publications:
> > "pub1"
> > "pub2"
> > Excluded from publications:
> > "pub3"
> >
> > ~~~
> >
>
> +1 for the proposal. It makes the description clear.
>
PSA v3 patches.
v3-0001 - Fixed the TABLE describe footer titles as suggested.
- "Included in publications:"
- "Excluded from publications:"
v3-0002 - Made similar footer title changes for SEQUENCE describe
v3-0003 - Made similar footer title changes for SHCEMA describe. In
passing, I found that this \dn describe output was not even being
tested, so I added the missing regression test.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-footer-titles-for-TABLE-describe.patch | application/octet-stream | 8.0 KB |
| v3-0003-Fix-footer-titles-for-SCHEMA-describe.patch | application/octet-stream | 2.7 KB |
| v3-0002-Fix-footer-titles-for-SEQUENCE-describe.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-04-20 03:38:13 | Re: Minor cleanup of Meson files given that we require 0.57 |
| Previous Message | David Rowley | 2026-04-20 01:30:25 | Re: First draft of PG 19 release notes |